Small cleanups to README#990
Merged
Matthias Schmidtblaicher (MatthiasSchmidtblaicherQC) merged 2 commits intomainfrom Mar 19, 2026
Merged
Small cleanups to README#990Matthias Schmidtblaicher (MatthiasSchmidtblaicherQC) merged 2 commits intomainfrom
Matthias Schmidtblaicher (MatthiasSchmidtblaicherQC) merged 2 commits intomainfrom
Conversation
Matthias Schmidtblaicher (MatthiasSchmidtblaicherQC)
marked this pull request as ready for review
Jan Tilly (jtilly)
approved these changes
Mar 19, 2026
Marc-Antoine Schmidt (MarcAntoineSchmidtQC)
approved these changes
Mar 19, 2026
Matthias Schmidtblaicher (MatthiasSchmidtblaicherQC)
merged commit de9be2f
into
main
25 checks passed
Matthias Schmidtblaicher (MatthiasSchmidtblaicherQC)
deleted the
update-readme
branch
Matthias Schmidtblaicher (MatthiasSchmidtblaicherQC)
added a commit
that referenced
this pull request
Mar 19, 2026
Matthias Schmidtblaicher (MatthiasSchmidtblaicherQC)
added a commit
that referenced
this pull request
Mar 23, 2026
* Add `train_deviance_path_` to `GeneralizedLinearRegressorCV` Expose training-set deviance alongside validation deviance so users can diagnose over-/under-fitting as regularization changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Relax train deviance assertion to avoid flaky test Compare overall means instead of per-alpha to avoid failures from unlucky CV splits or high-regularization alphas. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * small changes to changelog * Compute train deviance with standardized x_train * remove comment * test that train deviance is at correct scale; set to severe overfitting * remove scaling test because it is too obvious * simplify slightly * do save file * small comment why test deviance requires branching by fit_intercept * small overhang from #990 --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make code example reproducible by usingfetch_openmlinstead of a local parquet file.